fix(checks/no-focusable-disable): don't count non-disableable elements as disabled #3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `internal-link-present-evaluate` work with virtualNode rather than actualNode. Closes issue dequelabs#2466
This reverts commit 9f996bc.
…ractive" Closes issue dequelabs#2934
…dequelabs-develop-2
Dequelabs develop 2
work in progress
work in progress
This reverts commit 9f996bc.
…ractive" Closes issue dequelabs#2934
Now checks "disabled" attribute Closes issue dequelabs#3315
straker
previously requested changes
Feb 21, 2022
Co-authored-by: Steven Lambert <[email protected]>
|
Right on. Done. |
straker
approved these changes
Feb 22, 2022
|
reviewed for security |
straker
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
focusDisabled() now checks the element name to see if "disabled" attribute is valid on that element.
Closes issue #3315